fix: modified regex to use RE2

[RahulGautamSingh]

Changes:

Updated regex of these sub-folders:
lib/config
lib/constants
lib/datasource
to use RE2 using regEx function from lib/util/regex

Context:

fixes #11875

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

Checked config folder

[rarkins]

@viceice I think there are advantages to leaving the current regex positioning as-is - including inside for loops - for easier review and backwards compatibility. But then should we create an issue to elevate any regexes inside loops to be outside the loop?

[viceice]

@viceice I think there are advantages to leaving the current regex positioning as-is - including inside for loops - for easier review and backwards compatibility. But then should we create an issue to elevate any regexes inside loops to be outside the loop?

Yes, that was the idea. Sorry if it wasn't clear enough.

[rarkins]

@RahulGautamSingh please re-request a review once it's ready. The goals are:

• all regex which can be converted to regEx have been
• those which can't are marked with // TODO #12070
• any which should be moved out of loops are marked with // TODO #12071 (some may have both..)

[rarkins]

I got through 15/36 files before finding a lot of TODO #12070 which I have doubts about

[rarkins]

Ok, I will try going through the rest soon. I hadn't expected #12070 to have so many

[rarkins]

Looks mostly good except vscode settings

[RahulGautamSingh]

Hello @viceice @rarkins,
I have completed the work for the next PR, can you review & merge this one so that we can move next one OR should I create a new one?

[rarkins]

Needs deconflicting?

[RahulGautamSingh]

Needs deconflicting?

Yes. I created the new branch using this one so, all the changes made to this branch are already present in the other one. Therefore, unless this branch gets merged the changes will appear in the new branch and then conflicts.

[rarkins]

I'm confused. Which PR do you need merged first?

[RahulGautamSingh]

I'm confused. Which PR do you need merged first?

This one needs to be merged first.

[RahulGautamSingh]

Hey @rarkins @viceice ,
When I use RE2 syntax then in some cases while testing all the tests pass but the snapshots do not match. But when I delete the snaps and then test again then all the tests pass and the snaps (over-written) match.
I was wondering what to do in such cases, should I :-

1. Change the snapshots and use new Regex.
2. Deal with these in Refactor marked regex to be re2 compatible #12070.

[rarkins]

@RahulGautamSingh can you update this PR to include on such example where the snapshots need updating? Then it's easier for us to understand and decide

[RahulGautamSingh]

@RahulGautamSingh can you update this PR to include on such example where the snapshots need updating? Then it's easier for us to understand and decide

@rarkins
When I was rechecking the file to show an example of the error I found that the snapshots were fine and the real problem was incompatible RE2. I misunderstood the error the first time and thought that it was the snapshots. Sorry for the lapse in judgement. Also the files in which I had this problem are to be merged in future PRs.

This PR is okay to be merged and needs no further changes.

[RahulGautamSingh]

@rarkins It's been 4 hours since auto-merge but the PR hasn't been merged. Are there some requirements still to be met, I can't seem to find any?
Could the skipped test be causing this?

[rarkins]

Branches need to be up to date

[renovate-release]

🎉 This PR is included in version 28.1.7 🎉

The release is available on:

• GitHub release
• 28.1.7

Your semantic-release bot 📦🚀