Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bitbucket-pipelines): support bitbucket pipe renovations #11859

Merged
merged 11 commits into from
Oct 20, 2021
Merged

feat(bitbucket-pipelines): support bitbucket pipe renovations #11859

merged 11 commits into from
Oct 20, 2021

Conversation

olegkrivtsov
Copy link
Contributor

Changes:

Support Bitbucket Pipe Renovations #4647

Context:

Closes #4647

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins requested changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be made simpler if using YAML parsing instead?

lib/manager/bitbucket-pipelines/index.ts Outdated Show resolved Hide resolved
lib/manager/bitbucket-pipelines/index.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Sep 23, 2021
View reviewed changes
lib/manager/bitbucket-pipelines/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
olegkrivtsov and others added 2 commits September 24, 2021 09:20
@olegkrivtsov @viceice @rarkins
Apply suggestions from code review
2800b2f 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@olegkrivtsov
Modifications after code review
b33c25a
@rarkins rarkins requested a review from viceice September 24, 2021 09:10
viceice
viceice reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins I think yaml parsing would be some more complex, as we would need to itereate over a lot nested objects

lib/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
olegkrivtsov and others added 3 commits September 24, 2021 16:54
@olegkrivtsov @viceice
Update lib/manager/bitbucket-pipelines/extract.ts
d7b1ad3 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@olegkrivtsov @viceice
Update lib/manager/bitbucket-pipelines/extract.ts
43160ea 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@olegkrivtsov
Fix lint problem
60dd5ff
@rarkins rarkins requested a review from viceice September 26, 2021 19:28
@olegkrivtsov
Copy link
Contributor Author

Hi @rarkins I agree with @viceice that YAML parsing would be more complex. I think the current implementation is the simplest one.

viceice
viceice previously approved these changes Sep 30, 2021
View reviewed changes
@olegkrivtsov olegkrivtsov requested a review from rarkins October 4, 2021 13:06
@rarkins rarkins changed the title feat(manager/bitbucket-pipelines): support bitbucket pipe renovations feat(bitbucket-pipelines): support bitbucket pipe renovations Oct 4, 2021
@rarkins rarkins enabled auto-merge (squash) October 4, 2021 15:55
@rarkins rarkins merged commit 2d2a599 into renovatebot:main Oct 20, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 28.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Bitbucket Pipe Renovations
4 participants
@olegkrivtsov @renovate-release @viceice @rarkins