Misc cleanup, fix BUILD.md link

Signed-off-by: Joe Farro <joef@uber.com>
renovate-bot · Mar 16, 2019 · d315e14 · d315e14
1 parent eb16f51
commit d315e14
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 13 deletions.
diff --git a/BUILD.md b/BUILD.md
@@ -14,7 +14,7 @@ ESLint is being used to lint the repo, as a whole. Within `./packages/plexus` (f
 
 In the project root, `typescript` is used to bolster the linting of TypeScript files. `tsc` catches quite a few issues that ESLint does not pick up on.
 
-In `./packages/plexus`, `typescript` is used to generate type declarations for the ES module build. See [`./packages/plexus/BUILD.md`](packages/plexus/BUILD.md#TODO) for details.
+In `./packages/plexus`, `typescript` is used to generate type declarations for the ES module build. See [`./packages/plexus/BUILD.md`](packages/plexus/BUILD.md#typescript---emitdeclarationonly) for details.
 
 ### Workspaces
 

diff --git a/packages/plexus/demo/src/index.tsx b/packages/plexus/demo/src/index.tsx
@@ -122,4 +122,3 @@ function Demo() {
 }
 
 render(<Demo />, document.querySelector('#root'));
-console.log('yar');
diff --git a/packages/plexus/demo/template.ejs b/packages/plexus/demo/template.ejs
@@ -10,4 +10,4 @@
   <div id="<%= htmlWebpackPlugin.options.appMountId %>"></div>
 </body>
 
-</html>
+</html>
diff --git a/packages/plexus/src/types/index.tsx b/packages/plexus/src/types/index.tsx
@@ -69,14 +69,6 @@ export type TLayoutDone = {
   vertices: TLayoutVertex[];
 };
 
-// TODO(joe): delete if this is not needed
-// export type TLayout = {
-//   isCancelled: boolean,
-//   edges?: TLayoutEdge[],
-//   graph?: TLayoutGraph,
-//   vertices?: TLayoutVertex[],
-// };
-
 export type TPendingLayoutResult = {
   positions: Promise<TPositionsDone | TCancelled>;
   layout: Promise<TLayoutDone | TCancelled>;

diff --git a/packages/plexus/webpack-factory.js b/packages/plexus/webpack-factory.js
@@ -43,7 +43,7 @@ function makeBaseConfig() {
       rules: [
         {
           //
-          // Note: This `pre` is crucial (and not at all obvious)
+          // Note: This `pre` is crucial (and not exactly obvious)
           //
           enforce: 'pre',
           test: extensionsRx,

diff --git a/tsconfig.json b/tsconfig.json
@@ -17,7 +17,6 @@
     "jsx": "preserve"
   },
   "include": [
-    // TODO(joef)
     "packages/plexus/demo",
     "packages/plexus/src",
     // easier to add `./typings` here than deal with typeRoots, paths, etc.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -122,4 +122,3 @@ function Demo() {
		}

		render(<Demo />, document.querySelector('#root'));
		console.log('yar');
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,4 +10,4 @@ @@
       <div id="<%= htmlWebpackPlugin.options.appMountId %>"></div>
     </body>
-    </html>
+    </html>