Merged
Conversation
Collapses the common forget(id) + store(content) pattern into a single atomic call. When replace_id is set, the new item is stored first, then a SUPERSEDES edge is created, edges are transferred, and the old item is deleted. All replace sub-operations are non-fatal — the new item is stored regardless.
The ubuntu runner runs out of disk during linking. Free up space by removing unused SDK directories and drop the separate `cargo build` step since `cargo test` already compiles everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace_idoptional parameter to thestoretool, collapsing the commonforget(id)+store(content)two-call pattern into a single atomic operationreplace_idis set: stores new content, creates a SUPERSEDES graph edge, transfers edges from old to new, deletes the old item. All replace sub-operations are non-fatal.replaced_idfield and updated message on successful replacementTest plan
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test(all 80 tests pass)cargo test -- --ignored(integration teststest_store_replace_idandtest_store_replace_id_invalid)