Open
Conversation
- Platform-conditional data directory: Unix stays ~/.sediment/data, Windows uses %LOCALAPPDATA%\sediment\data - Fix atomic rename in write_config_atomic() for Windows - Add x86_64-pc-windows-msvc target to release workflow with zip packaging - Add windows-latest to CI test matrix - Add PowerShell install script (install.ps1) - Update README with Windows platform info and install instructions
The verbose output generates large runner diagnostic logs that fill the ubuntu-latest runner's disk during test compilation.
The test binary linking runs out of disk space on ubuntu-latest runners. Remove unused pre-installed software (.NET, Android SDK, GHC) to reclaim space. Also combine build+test into a single cargo test step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%LOCALAPPDATA%\sediment\dataon Windows,~/.sediment/dataunchanged on Unix)write_config_atomic()for Windows (rename fails if destination exists)x86_64-pc-windows-msvctarget to release workflow with.zippackagingwindows-latestto CI test matrixinstall.ps1)Test plan
cargo fmt --all -- --checkpassescargo clippy --all-targets -- -D warningspassescargo testpasses (80 passed, 27 ignored)central_db_path()still returns~/.sediment/dataon Unix