Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow closing popovers by right clicking the curtain #720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Allow closing popovers by right clicking the curtain #720

wants to merge 1 commit into from

Conversation

jespertheend
Copy link
Collaborator

Fixes #442

@jespertheend
Copy link
Collaborator Author

Seems like e2e tests are failing because clicking items in contextmenus isn't working anymore.
The reason being that preventDefault() is preventing the click event from firing.
Normally the this.#activePopovers.some() statement should prevent this, but submenus aren't properly added to the popovermanager. (#515)

@jespertheend
Copy link
Collaborator Author

Another problem seems to be that it's no longer possible to drag assets to the entry point popover in the build view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close popovers by right clicking the curtain
1 participant
@jespertheend