Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate scala-stm benchmarks from Scala 2.12 to Scala 3 #445

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

lbulej
Copy link
Member

@lbulej lbulej commented May 27, 2024

Migrates the scala-stm benchmarks to Scala 3 (skipping Scala 2.13), leaving only the reactors benchmark to be migrated to at least Scala 2.13 (#324).

Below are plots from simple measurements I collected from 15 runs (150 repetitions each) using JDK 11 (default settings) on 8 cores of Xeon E5-2697A v4:

  • the scala212 variant corresponds to commit 87358d9 (Renaissance 0.15.0, scala-stm 0.8 with Scala 2.12.18)
  • the scala3_stm variant corresponds to commit 6d1cb1f (scala-stm 0.11.1 with Scala 3.3.1)

plot-runs-samples
plot-runs-histograms
plot-runs-violins

Replaces the call to Class.newInstance() with call to
Constructor.newInstance().
Also updates the order of annotations to avoid changing the benchmark
primary group when compiled with Scala 3.
@lbulej
Copy link
Member Author

lbulej commented Jun 7, 2024

Rebased to master after merging #444.

@lbulej lbulej assigned farquet and axel22 and unassigned axel22 and farquet Jun 7, 2024
@lbulej lbulej requested a review from axel22 June 11, 2024 20:18
@lbulej lbulej requested a review from ceresek June 19, 2024 15:23
Copy link
Collaborator

@farquet farquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@axel22 axel22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lbulej lbulej merged commit a3ac3bb into master Jul 17, 2024
13 checks passed
@lbulej lbulej deleted the devel/scala-stm-scala3 branch July 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants