Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Neo4j to version 5.12.0 and migrate to Scala 2.13 #422

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

lbulej
Copy link
Member

@lbulej lbulej commented Oct 11, 2023

This makes neo4j-analytics compatible with JDK21, but requires JDK17 to run.

This makes `neo4j-analytics` compatible with JDK21.
After upgrading Neo4j to version 5.12.0, having play-json at version
2.10.1 causes Renaissance compilation failure when SBT is running on
Java 8, because sbt.internal.inc.AnalyzingCompiler and eventually the
scala.tools.nsc.typechecker.AnalyzerPlugins classes end up trying to
load Java 11 classes in to Java 8 runtime.

This is a temporary solution until we drop Java 8 from CI.
@lbulej lbulej requested a review from farquet October 11, 2023 15:55
@lbulej lbulej marked this pull request as ready for review October 11, 2023 15:55
Copy link
Collaborator

@farquet farquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lbulej lbulej merged commit ae761c6 into master Oct 12, 2023
15 checks passed
@lbulej lbulej deleted the devel/neo4j branch October 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants