Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native dependencies in db-shootout #171

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Conversation

farquet
Copy link
Collaborator

@farquet farquet commented Jul 2, 2019

This should solve #153 since it removes the problematic dependencies of LevelDB.

Iteration time goes down from 5800ms to 4500ms on my machine (28%).

Copy link
Collaborator

@Fithos Fithos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@axel22 axel22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farquet farquet merged commit eca0bd2 into master Jul 3, 2019
@farquet farquet deleted the dbshootout-no-native branch July 3, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants