Fix finagle-chirper

[Fithos]

This PR implements the comments by @vkostyukov in issue #106 (see #106 (comment)).

Since the crash mentioned in #106 never occurred on the machines at my disposal, additional testing would be helpful. In case the crash still occurs, we can leave this PR open until a proper fix is implemented.

[axel22]

Should this one be getting closed too:

https://github.com/renaissance-benchmarks/renaissance/pull/136/files#diff-21e7e8759130ae3ea77f1e2657b0d8e1R284

[axel22]

cc @vkostyukov

[farquet]

That would really awesome if @vkostyukov could review this PR and more generally give his blessing to the finagle-chirper and finagle-http benchmarks.

[Fithos]

Should this one be getting closed too:

https://github.com/renaissance-benchmarks/renaissance/pull/136/files#diff-21e7e8759130ae3ea77f1e2657b0d8e1R284

Good point. Fixed.

[vkostyukov]

Thanks for fixing this @Fithos! This LGTM.

[Fithos]

Thanks for fixing this @Fithos! This LGTM.

Thanks for your feedback, @vkostyukov!

[ceresek]

Testing, should know by tomorrow if it still leaks ...

[ceresek]

No crash or apparent leak after 12+ hours of execution on a machine where otherwise we saw a crash after ~3 hours, so looks like this is fixed. Thank you !

@vkostyukov Vladimir, with your Finagle expertise, would you mind becoming a collaborator ? Obviously we could use an occasional kick hint with our Finagle related code.

[Fithos]

I think we can close this PR and go ahead with merging.
How shall we handle bug fixing wrt. releases? I.e., shall we release a v.0.9.1, according to semantic versioning?

[ceresek]

Yes, 0.9.1 makes sense. What I'm not sure is if we should base it off 0.9 or current master ... ?

[farquet]

IMO, taking master is a reasonable choice since there were other bugfixes merged since the 0.9.0 release (Spark port allocation or preventing extra work in first iteration of Scrabble 7ee7375).
Moreover, keeping a separate release branch would add extra complexity in maintenance and will have to decide what to cherrypick or not and I don't think it's a too risky move to use master.

Btw, regarding result publishing, we could consider showing the release version number somewhere on the home page next to the charts.

[axel22]

I agree, we should keep just one dev branch, IMO.