-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodemon won't restart webpack-serve #1409
Comments
This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up. |
This is still a problem AFAIK. |
This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up. |
Still a problem. I looked at the code briefly and it seems like there may be a logic error, I'll submit a PR for feedback. |
This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up. |
this is a fun dance mr. stale bot. PR is here: #1430 |
This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up. |
💃 |
This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up. |
😿 |
When nodemon kills the child app in preparation for a restart, the app may exit with a non-zero status code, especially when using custom signals like SIGINT. Previously, this would be detected as a clean exit rather than a restart, at least on macOS. There was an existing flag, `killedAfterChange` which causes the desired behavior, but it was only set on Windows. It seems that setting it always leaked between tests and caused problems, so we only set it if a restart is expected. Fixes remy#1409
I wish the damn stalebot wouldn't come back after it's been told to effoff! Or at least wait exponentially longer! |
Aye, agreed. Thanks for the merge! |
nodemon -v
: 1.18.3node -v
: v8.10.0Expected behaviour
When
webpack.config.js
changes, I'd expect it to restart webpack-serveActual behaviour
It detects a "clean exit" and does not restart:
Steps to reproduce
git clone git@github.com:aaronjensen/nodemon-repro.git cd nodemon-repro yarn yarn start
Then make a change to
webpack.config.js
Of note is that I had to add
--signal SIGINT
because I typically run nodemon inside ofstmux
. If it's running inside ofstmux
, it does not properly die whenstmux
is killed. This may be another bug, though I don't know where the bug may be.To reproduce that, run
yarn start:stmux
and then hitCtrl-a k
Perhaps I'm doing something entirely wrong here, but I couldn't find any other examples or docs. Any pointers would be appreciated, thanks!
The text was updated successfully, but these errors were encountered: