feat: Skipping failed tests from JSON-Schema-Test-Suite #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll re-enable them once the feature is implemented. feat: Skipping failed tests from JSON-Schema-Test-Suite We'll re-enable them once the feature is implemented. fix: typo fix: typo
antoniocapelo
force-pushed
the
devxp-2603-use-json-schema-test-suite-refactor
branch
from
956c227 to
0728e56
Compare
antoniocapelo
requested review from
thien-remote,
lukad,
sandrina-p and
dragidavid
thien-remote
previously approved these changes
Feb 7, 2025
thien-remote
approved these changes
Feb 7, 2025
|
Little late to the party but this looks great @antoniocapelo - thanks! |
antoniocapelo
deleted the
devxp-2603-use-json-schema-test-suite-refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On top of our test cases, we're running the JSON-Schema-Test-Suite. However, until all features are implemented, some of the tests in this suite would fail.
We're using a custom jest reporter to keep track of the tests that are failing (on a dedicated file), so we can re-enable them once the feature is implemented.
Note: The failed tests are not being saved to file every time the suite runs, as this could cause for bugs to surface due to a change in the codebase. The
SHOULD_WRITE_FAILED_TESTS_TO_FILEconstant on the custom reporter can be set totrueto write the failed tests to a file (on-demand), for later consumption at thejson_schema_test_suite.test.jsfile.