-
Notifications
You must be signed in to change notification settings - Fork 23
add typings for HTTPS agent for fetch and Request #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add typings for HTTPS agent for fetch and Request #18
Conversation
🦋 Changeset detectedLatest commit: a9da0a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mcansh - trying to add a change set but I only see the option to make a |
if you hit enter without selecting a package, it should prompt for minor and then patch. however you can always change the changeset after :) however, i usually just do it via the changeset bot prompt |
|
Updated to patch in a following commit 😄 EDIT: updating to |
1319655 to
a9da0a7
Compare
|
Updated |
|
@mcansh - any other changes you think I should make? |
sorry @cliffordfajardo i was out the last 2 weeks, but was popping in and out of GitHub, I'll get this reviewed shortly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, gonna get another approval real quick before merging :)
Co-authored-by: Clifford Fajardo <cfajardo@linkedin.com>
* fix: add typings for HTTPS agent for fetch and Request (remix-run#18) Co-authored-by: Clifford Fajardo <cfajardo@linkedin.com> * chore: fix changeset --------- Co-authored-by: Clifford Fajardo <cliffordfajardo@gmail.com> Co-authored-by: Clifford Fajardo <cfajardo@linkedin.com> Co-authored-by: Irakli Gozalishvili <contact@gozala.io>

What is the change?
httpsagentoptionsparamWhy are we making this change?
httpsto `RequestRequestExtraOptionsvalues to be passed tofetchTests
Type changes only. Ran npm test inside of
package/fetchand all tests passTest output for `package/fetch`