Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/envvars): update Cloudflare description #8018

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jabranr
Copy link

@jabranr jabranr commented Nov 15, 2023

This is true for both Cloudflare Pages and Workers-site with Remix v2.

This is true for both Cloudflare pages and worker-site with Remix v2.
Copy link

changeset-bot bot commented Nov 15, 2023

⚠️ No Changeset found

Latest commit: aa9e982

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 15, 2023

Hi @jabranr,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 15, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@@ -46,7 +46,7 @@ export async function loader() {
}
```

If you're using the `@remix-run/cloudflare-pages` adapter, env variables work a little differently. Since Cloudflare Pages are powered by Functions, you'll need to define your local environment variables in the [`.dev.vars`][dev-vars] file. It has the same syntax as `.env` example file mentioned above.
If you're using the `@remix-run/cloudflare` adapter, env variables work a little differently. Since Cloudflare Pages are powered by Functions, you'll need to define your local environment variables in the [`.dev.vars`][dev-vars] file. It has the same syntax as `.env` example file mentioned above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Cloudflare Pages are powered by Functions

Do we need to alter the wording here too if it's applicable to both pages and workers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It now applies to both Pages and Worker sites equally although there is a difference still behind the scenes i.e.

  • CF Pages are still powered by Functions
  • CF Workers with module syntax will only pass environment variables to the context
  • CF Workers with service worker syntax (legacy) enable the environment variables globally

The whole paragraph may need a bit of redo.

@MichaelDeBoey MichaelDeBoey changed the title Update docs docs(guides/envvars): update Cloudflare description Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants