fix(dev): update esbuild, tree shake CSS bundle #7374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Type |
|---|---|
| create-remix | Patch |
| remix | Patch |
| @remix-run/architect | Patch |
| @remix-run/cloudflare | Patch |
| @remix-run/cloudflare-pages | Patch |
| @remix-run/cloudflare-workers | Patch |
| @remix-run/css-bundle | Patch |
| @remix-run/deno | Patch |
| @remix-run/dev | Patch |
| @remix-run/eslint-config | Patch |
| @remix-run/express | Patch |
| @remix-run/node | Patch |
| @remix-run/react | Patch |
| @remix-run/serve | Patch |
| @remix-run/server-runtime | Patch |
| @remix-run/testing | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
pcattori
approved these changes
Sep 12, 2023
MichaelDeBoey
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since esbuild v0.17.7+ no longer tree shakes CSS and this means we're stuck on esbuild v0.17.6, this PR is an experiment to see if we can manually tree shake CSS by performing two esbuild passes during the CSS bundle build. The first esbuild pass is effectively the same as before, except now we keep all generated CSS files in memory. We then check which files were referenced in the JS output and use this as input to a 2nd esbuild pass containing only referenced CSS files.
This PR is currently against the
release-nextbranch so that it's up to date with the latest compiler code, but if it lands it's likely to go indev.