fix: use headers.entries() instead of headers.raw()

[MichaelDeBoey]

Closes #4354

[changeset-bot]

🦋 Changeset detected

Latest commit: 0689d14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/architect	Patch
@remix-run/express	Patch
@remix-run/serve	Patch
@remix-run/dev	Patch
create-remix	Patch
remix	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[brophdawg11]

@mjackson the move to raw came from #241 - do you have context on whether it's safe to switch back?

[brophdawg11]

This breaks for me since entries returns strings, not arrays in values like raw did so this then iterates over the characters in the values string.

I think the original bug actually boils down to a bug in the node-fetch entries implementation (which we inherited into the Remix fork) - I pushed a potential fix here: remix-run/web-std-io#39

If we were to merge that fix, then I think this would become:

Suggested change

	for (let [key, values] of nodeResponse.headers.entries()) {
	for (let value of values) {
	res.append(key, value);
	}
	for (let [key, value] of nodeResponse.headers.entries()) {
	res.append(key, value);

[brophdawg11]

Requesting changes just to keep this on hold until we can get remix-run/web-std-io#39 merged.

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-1d3d86e-20230817 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!