feat(cloudflare+cloudflare-pages+cloudflare-workers+templates): add support for @cloudflare/workers-types v3
#645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
force-pushed
the
dev
branch
2 times, most recently
from
ab9dac4 to
172ecc9
Compare
2 tasks
MichaelDeBoey
changed the title
@cloudflare/workers-types v3
|
@edmundhung Could you please rebase your branch onto latest Also don't forget to update the |
MichaelDeBoey
added
the
needs-response
|
Yeah this would be great, thanks Edmund 😊 |
2 tasks
@MichaelDeBoey I have opened a new PR #2530 as I accidentally deleted the original fork repository and now I cannot push any commit to this PR anymore. (Edit: Feel free to close this PR after you check the message) |
github-actions
bot
removed
the
needs-response
|
Closing in favour of #2530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare released an update for
@cloudflare/workers-typeslast month. It is now automatically generated from the source as announced here and this ensures typing to be always up-to-dated with the latest runtime.However, the current CF adapter has a peerDependency of v2 only. It would be nice if we could add support of v3 as well.
This will also makes experimenting with new ESM worker easier (as all new types are only defined on v3) before official support is ready.
Thanks for all the great work!