-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(remix-dev): add failing test for 'multiple routes with the same route module' #1898 #3684
Conversation
|
Hi @AndrewLeedham, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
@AndrewLeedham can you please sign the CLA so that we can run the failing test? |
@machour I plan to do both, I just haven't got clearance from my company yet. |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@MichaelDeBoey I tried fixing this, but it seems like changing IDs would be a breaking change. Where would be best to discuss this problem? |
Closes: #1898
Testing Strategy:
I added a failing test to show that multiple routes pointing at a single route module get overwritten.