fix(remix-react): make LiveReload
work for ports other than 8002
#2456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if
config.devServerPort
was changed either manually or automatically (something already running on 8002), the port inlined to LiveReload was 8002 anyways. I went through some testing locally innode_modules
and this was the solution. with our current testing infrastructure, I wasn't sure where to write a test for this, so if anyone has an idea, please let me know :)Signed-off-by: Logan McAnsh logan@mcan.sh
Closes: #