Skip to content

Conversation

mcansh
Copy link
Contributor

@mcansh mcansh commented Mar 22, 2022

Prior to this change, if config.devServerPort was changed either manually or automatically (something already running on 8002), the port inlined to LiveReload was 8002 anyways. I went through some testing locally in node_modules and this was the solution. with our current testing infrastructure, I wasn't sure where to write a test for this, so if anyone has an idea, please let me know :)

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

  • Docs
  • Tests

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh marked this pull request as ready for review March 23, 2022 13:58
@mcansh mcansh linked an issue Mar 23, 2022 that may be closed by this pull request
@MichaelDeBoey MichaelDeBoey changed the title fix(remix-react): make live reload work for ports other than 8002 fix(remix-react): make LiveReload work for ports other than 8002 Mar 28, 2022
@mcansh mcansh merged commit 93da48e into dev Apr 1, 2022
@mcansh mcansh deleted the logan/rem-821-dev-server-port branch April 1, 2022 17:50
@kentcdodds
Copy link
Member

This caused an issue where port is undefined in the inline script. I noticed and made a PR to fix it, but then realized that this had been removed. Could you look into this further? #2662

I'm guessing my PR isn't enough, but this PR breaks livereload 😬

@mcansh
Copy link
Contributor Author

mcansh commented Apr 6, 2022

super weird, when i was fumbling through node_modules to make this change, everything was happy-go-lucky, diving into it now

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

🤖 Hello there,

We just published version v1.3.5-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run remix run on multiple apps at once

4 participants