-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cache user public files as immutable #10441
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6c7e9f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @remorses, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Why do you have user files in |
Files in /public folder are moved to build/client by Vite |
But that's build time thing, after you build the app and deploy it any file in public folder is not touched anymore. |
The Remix
build.assetsBuildDirectory
isbuild/client
, this folder contains user public files. The serve code is caching these files as immutable which means that even if the user changes the content of a file but not the name the file it will not be revalidated.This PR makes immutable only files generated by Remix, which contain an hash in the name. Files in
public
will be cached only for 1 hour instead.Fix #9353