Do not cache user public files as immutable

[remorses]

The Remix build.assetsBuildDirectory is build/client, this folder contains user public files. The serve code is caching these files as immutable which means that even if the user changes the content of a file but not the name the file it will not be revalidated.

This PR makes immutable only files generated by Remix, which contain an hash in the name. Files in public will be cached only for 1 hour instead.

Fix #9353

[changeset-bot]

🦋 Changeset detected

Latest commit: 9fae2f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages

Name	Type
@remix-run/serve	Patch
@remix-run/dev	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/fs-routes	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/route-config	Patch
@remix-run/routes-option-adapter	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @remorses,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[sergiodxa]

Why do you have user files in build/client folder? That should only include the files generated at build time and hashed. If you're uploading user files to your file system you should add them in the public folder.

[remorses]

Files in /public folder are moved to build/client by Vite

[sergiodxa]

But that's build time thing, after you build the app and deploy it any file in public folder is not touched anymore.

[github-actions]

Thank you for opening this pull request, and our apologies we haven't gotten around to it yet!

With the release of React Router v7 we are sun-setting continued development/maintenance on Remix v2. If you have not already upgraded to React Router v7, we recommend you do so. We've tried to make the upgrade process as smooth as possible with our Future Flags. We are now in the process of cleaning up outdated issues and pull requests to improve the overall hygiene of our repositories.

We plan to continue to address 2 types of issues in Remix v2:

• Bugs that pose security concerns
• Bugs that prevent upgrading to React Router v7

If you believe this pull request meets one of those criteria, please respond or create a new pull request so it pops up on our radar (since github notifications may get lost in the noise 😕).

For all other issues/changes, ongoing maintenance will be happening in React Router v7, so:

• If this is a bug fix, please reopen against React Router v7
• If this is a new feature, please open a new Proposal Discussion in React Router, and if it gets enough community support it can be considered for implementation

If you have any questions you can always reach out on Discord. Thanks again for providing feedback and helping us make our framework even better!