Skip to content

Update github New Issue workflow to mimic Remix #9839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jan 9, 2023

  • Update the .github/ISSUE_TEMPLATE/config.yml configuration to send feature requests through the new Proposal workflow
  • Added a new template for documentation issues to add a [Docs]: prefix and the docs label.
  • Also did some cleanup of the examples/data-router app since we link to that from the issue template now

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2023

⚠️ No Changeset found

Latest commit: 16ff60a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


- Read the docs: https://reactrouter.com
- Check out the list of frequently asked questions: https://reactrouter.com/start/faq
- Explore examples: https://reactrouter.com/start/examples
- Ask in chat: https://rmx.as/discord
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the old Reactiflux discord link in favor of the Remix discord, and moved it above stack overflow

Comment on lines +27 to +28
* (Using `<RouterProvider>`)[https://stackblitz.com/github/remix-run/react-router/tree/main/examples/data-router?file=src/App.tsx]
* (Using `<BrowserRouter>`)[https://stackblitz.com/github/remix-run/react-router/tree/main/examples/basic?file=src/App.tsx]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to separate examples of RouterProvider/BrowserRouter for clarity

Comment on lines -3 to +20
- name: 🤔 Support/Usage Question
- name: 💡 Feature Request
url: https://github.com/remix-run/react-router/discussions/new?category=proposals
about:
If you've got an idea for a new feature in React Router, please open a new
Discussion with the `Proposals` label. We'll review the most popular
proposals on a regular basis. Read more about our Open Development process
[here](https://remix.run/blog/open-development).
- name: 🤔 Usage Question (Stack Overflow)
url: https://stackoverflow.com/questions/tagged/react-router
about: This is a bug tracker, not a support system. For usage questions, please use Stack Overflow where there are a lot more people ready to help you out. Thanks!
about: Open a question in Stack Overflow with the react-router label
- name: 🤔 Usage Question (Github Discussions)
url: https://github.com/remix-run/remix/discussions/new?category=q-a
about: Open a Discussion in GitHub wih the `Q&A` label
- name: 💬 Remix Discord Channel
url: https://rmx.as/discord
about: Interact with other people using React Router and Remix 📀. There's
plenty of channels for general discussions as well as a threaded `#help`
channel in here where you can ask for help with you issue.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo,
sleep,
AwaitPage,
} from "./routes";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got rid of the separate routes.tsx file so everything is in app.tsx now

@@ -0,0 +1,21 @@
name: 📚 Documentation Issue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of documentation updates filed as bugs so added a separate template here for those

@brophdawg11 brophdawg11 merged commit 482b6a2 into main Jan 11, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/github-issue-workflow branch January 11, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants