Updated some devDependencies to fix audit warnings #6741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've found it quite tedious as well. I had to do it for each package and then run lerna at the root to ensure there aren't too many hoisting warnings. I suppose there's some way lerna can manage this for us, but I haven't played with it enough to figure it out. I'm actually not 100% sure we need lerna, since it doesn't do that much for us 🤷♂️ Anyways, this should be good. Thanks! Edit: Wait, there are conflicts now. I'm on mobile, so I can't resolve them right now. |
timdorr
approved these changes
May 11, 2019
|
Rebased it to master and fixed the conflicts. |
|
Danke. |
|
Gern geschehen :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all
npm auditwarnings.A point of interest might be the css-loader upgrade in
/website, as I had to lift it by 2 major versions. I couldn't find any breakages.I also removed
babel-coreas it's no longer needed with jest@24 and upped jest in general.On a related note: How is one supposed to update devDependencies in a monorepo anyway? I did this by hand for the 4 packages and the website and it's quite tedious.