Skip to content

Fixtures for HMR & HDR test #14403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 1, 2025
Merged

Fixtures for HMR & HDR test #14403

merged 6 commits into from
Oct 1, 2025

Conversation

@pcattori
Copy link
Contributor

@pcattori pcattori commented Sep 30, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: aa994de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pcattori
pcattori commented Sep 30, 2025
View reviewed changes
integration/vite-hmr-hdr-test.ts
Comment on lines -67 to -68
"vite.config.js": await viteConfig.basic({ port, templateName }),
"server.mjs": EXPRESS_SERVER({ port, templateName }),
Copy link
Contributor Author

@pcattori pcattori Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we set up Vite's port and hmrPort in viteConfig.basic. Turns out, when using middleware mode, only hmrPort matters. Also, rather than overly templatizing the Express server.mjs, I chose to use env vars for the inputs (port & HMR port) and separate functions for RSC and non-RSC modes (though I wouldn't be opposed to a wrapping funciton like Express.server({ rsc: true }) )

@pcattori pcattori force-pushed the pedro/fixtures-for-hmr-hdr-test branch from 8c0bff8 to aa994de Compare October 1, 2025 17:21
@pcattori pcattori marked this pull request as ready for review October 1, 2025 17:24
@pcattori pcattori merged commit 368e0cb into dev Oct 1, 2025
8 checks passed
@pcattori pcattori deleted the pedro/fixtures-for-hmr-hdr-test branch October 1, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed pkg:@react-router/dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcattori @brophdawg11