-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Inject client route component props during RSC render #14007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject client route component props during RSC render #14007
Conversation
🦋 Changeset detectedLatest commit: e6a8a30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| type WindowWithRouterGlobals = Window & | ||
| typeof globalThis & { | ||
| __router: DataRouter; | ||
| __routerInitialized: boolean; | ||
| __routerActionID: number; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work in this PR triggered new type errors, seemingly due to the global types leaking out of the library. I think it was due to the new internal import, but I'm not sure. As a workaround I introduced this to avoid touching global types. We can look into this, but I didn't want it to block this PR.
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
We're now wrapping all client route components to ensure that all props match the equivalent values you'd get from the hooks, e.g.
loaderDatawill include client loader data, whereas previously this prop would only ever be the server loader data.