Skip to content

Conversation

@markdalgleish
Copy link
Member

We're now wrapping all client route components to ensure that all props match the equivalent values you'd get from the hooks, e.g. loaderData will include client loader data, whereas previously this prop would only ever be the server loader data.

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: e6a8a30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +57 to +62
type WindowWithRouterGlobals = Window &
typeof globalThis & {
__router: DataRouter;
__routerInitialized: boolean;
__routerActionID: number;
}
}
};
Copy link
Member Author

@markdalgleish markdalgleish Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work in this PR triggered new type errors, seemingly due to the global types leaking out of the library. I think it was due to the new internal import, but I'm not sure. As a workaround I introduced this to avoid touching global types. We can look into this, but I didn't want it to block this PR.

@brophdawg11 brophdawg11 merged commit 7150677 into release-next Jul 16, 2025
14 checks passed
@brophdawg11 brophdawg11 deleted the markdalgleish/rsc-client-route-wrapper-components branch July 16, 2025 13:35
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants