Skip to content

docs(how-to/spa): remove duplicated text #13975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025
Merged

Conversation

HelpMe-Pls
Copy link
Contributor

There's a <docs-info> tag below with the EXACT same content.

There's a `<docs-info>` tag below with the EXACT same content.
Copy link

changeset-bot bot commented Jul 11, 2025

⚠️ No Changeset found

Latest commit: 84fa28a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 11, 2025

Hi @HelpMe-Pls,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@MichaelDeBoey MichaelDeBoey changed the title Remove duplicated text docs(how-to/spa): remove duplicated text Jul 11, 2025
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be intentionally done by @brookslybrand in #13005

@brophdawg11
Copy link
Contributor

@HelpMe-Pls Could you sign the CLA?

@brookslybrand
Copy link
Contributor

brookslybrand commented Jul 11, 2025

Oh yeah, that is a little silly

@HelpMe-Pls if you'll sign the CLA we can go ahead and merge this :)

edit: jinx @brophdawg11

@HelpMe-Pls HelpMe-Pls marked this pull request as draft July 12, 2025 03:14
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 12, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@HelpMe-Pls
Copy link
Contributor Author

Ah @brookslybrand, you're the guy who made the tutorial video!
Tysm for making react-router more accessible for people like me.

@HelpMe-Pls HelpMe-Pls marked this pull request as ready for review July 12, 2025 03:40
@timdorr
Copy link
Member

timdorr commented Jul 12, 2025

Thanks!

@timdorr timdorr merged commit 85e7537 into remix-run:main Jul 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants