Remove hashes on built filenames #13567

brophdawg11 · 2025-05-08T21:22:05Z

Only done for the RR package currently but can adopt in the other packages if this is the way to go

I'm pretty sure we got the extracted (and hashed) chunk before because we built index.ts and dom-export.ts in the same config. It then extracted the shared code (all of index.ts) into a chunk.

By giving these to tsup in different configs, it doesn't identify that code as shared and doesn't extract to a chunk. And by marking react-router as external it causes the dom exports to just require/import it correctly and not bundle it.

The output with this config looks like:

packages/react-router/dist/
├── development
│   ├── dom-export.d.mts
│   ├── dom-export.d.ts
│   ├── dom-export.js
│   ├── dom-export.mjs
│   ├── index.d.mts
│   ├── index.d.ts
│   ├── index.js
│   ├── index.mjs
│   ├── internal.d.mts
│   ├── internal.d.ts
│   ├── internal.js
│   └── internal.mjs
└── production
    ├── dom-export.d.mts
    ├── dom-export.d.ts
    ├── dom-export.js
    ├── dom-export.mjs
    ├── index.d.mts
    ├── index.d.ts
    ├── index.js
    ├── index.mjs
    ├── internal.d.mts
    ├── internal.d.ts
    ├── internal.js
    └── internal.mjs

Alternate approach:

I also tried a simpler approach of using splitting: false with external: ['react-router'] (see 7ad3bed) but that still generates some hashed files. However - I don't think we get the typegen E2E test failures with this config so unsure what the difference is there yet.

packages/react-router/dist/
├── development
│   ├── dom-export.d.mts
│   ├── dom-export.d.ts
│   ├── dom-export.js
│   ├── dom-export.mjs
│   ├── index.d.mts
│   ├── index.d.ts
│   ├── index.js
│   ├── index.mjs
│   ├── lib
│   │   └── types
│   │       ├── internal.d.mts
│   │       ├── internal.d.ts
│   │       ├── internal.js
│   │       └── internal.mjs
│   ├── register-BPC2Sp5k.d.mts
│   └── register-BPC2Sp5k.d.ts
└── production
    ├── dom-export.d.mts
    ├── dom-export.d.ts
    ├── dom-export.js
    ├── dom-export.mjs
    ├── index.d.mts
    ├── index.d.ts
    ├── index.js
    ├── index.mjs
    ├── lib
    │   └── types
    │       ├── internal.d.mts
    │       ├── internal.d.ts
    │       ├── internal.js
    │       └── internal.mjs
    ├── register-BPC2Sp5k.d.mts
    └── register-BPC2Sp5k.d.ts

changeset-bot · 2025-05-08T21:22:09Z

🦋 Changeset detected

Latest commit: 893f9cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
react-router	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/dev	Patch
react-router-dom	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pcattori · 2025-05-08T21:30:58Z

packages/react-router/tsup.config.ts

+  ...config("index.ts", false),
+  ...config("index.ts", true),
+  ...config("dom-export.ts", false),
+  ...config("dom-export.ts", true),
+  ...config("lib/types/internal.ts", false),
+  ...config("lib/types/internal.ts", true),


Does having separate bundle configs create unique files for each bundle? ie. if two bundles depend on the same source file, does each bundle get its own copy? I remember something like that happening before and unifying the entries into a single config fixed it, but I could be misremembering

It does but the external config lets us avoid that. Without external: ['react-router'] it would dup the react router code in index and dom-export, but using that config, dom-export just does import {} from 'react-router' and it resolves through to the index file.

brophdawg11 · 2025-05-09T13:59:50Z

@pcattori I think there is still a type issue here from the typegen e2e test, locally it looks like the params weren't resolving right but I'm unsure what about this change would have caused that

This reverts commit 7ad3bed.

brophdawg11 · 2025-05-15T15:02:14Z

packages/react-router/index.ts

@@ -277,7 +277,7 @@ export type {
  MiddlewareEnabled as UNSAFE_MiddlewareEnabled,
 } from "./lib/types/future.ts";
 export type { unstable_SerializesTo } from "./lib/types/serializes-to.ts";
-export type { Register } from "./lib/types/register";
+export type { Register, Pages, RouteFiles } from "./lib/types/register";


Now exported as public API from react-router for consumption by react-router/internal

brophdawg11 · 2025-05-15T15:07:17Z

packages/react-router/internal-export.ts

+    params: Params<T["file"]>;
+    loaderData: GetLoaderData<T["module"]>;
+    actionData: GetActionData<T["module"]>;
+  };


Lifted to the root to align with our dom-export.ts file

brophdawg11 · 2025-05-15T15:10:00Z

integration/prefetch-test.ts

@@ -172,7 +172,7 @@ test.describe("prefetch", () => {
          await page.waitForSelector(
            // Look for either Rollup or Rolldown chunks
            [
-              "link[rel='modulepreload'][href^='/assets/chunk-']",
+              "link[rel='modulepreload'][href^='/assets/index-']",


I confirmed this is just a rename of a dist file but the contents are the same - it's the built file containing react and react router:

# Old: vite v6.1.1 building for production... ✓ 44 modules transformed. build/client/.vite/manifest.json 1.97 kB │ gzip: 0.40 kB build/client/assets/_index-CIzFY5VO.js 0.20 kB │ gzip: 0.18 kB build/client/assets/prefetch-with-loader-DSdeOoqs.js 0.21 kB │ gzip: 0.19 kB build/client/assets/prefetch-without-loader-RubElpnG.js 0.22 kB │ gzip: 0.19 kB build/client/assets/with-props-Cx2GuqjJ.js 0.22 kB │ gzip: 0.19 kB build/client/assets/root-BX6sQn4U.js 0.73 kB │ gzip: 0.38 kB build/client/assets/chunk-23TDSFDP-DRRB-IEc.js 131.31 kB │ gzip: 43.82 kB 👈 build/client/assets/entry.client-Dsu8FA8V.js 339.28 kB │ gzip: 101.90 kB # New vite v6.1.1 building for production... ✓ 43 modules transformed. build/client/.vite/manifest.json 1.89 kB │ gzip: 0.38 kB build/client/assets/_index-P-ZakiLo.js 0.19 kB │ gzip: 0.17 kB build/client/assets/prefetch-with-loader-COazqWjd.js 0.20 kB │ gzip: 0.18 kB build/client/assets/prefetch-without-loader-CD33gy26.js 0.21 kB │ gzip: 0.18 kB build/client/assets/with-props-06UYi0rd.js 0.21 kB │ gzip: 0.18 kB build/client/assets/root-C717KEjd.js 0.72 kB │ gzip: 0.37 kB build/client/assets/index-DRRB-IEc.js 131.31 kB │ gzip: 43.82 kB 👈 build/client/assets/entry.client-B9qJACK4.js 339.27 kB │ gzip: 101.88 kB

brophdawg11 · 2025-05-15T15:34:28Z

packages/react-router/lib/dom/lib.tsx

@@ -94,7 +94,7 @@ import {
  useResolvedPath,
  useRouteId,
 } from "../hooks";
-import type { SerializeFrom } from "../types/route-data";
+import type { SerializeFrom } from "../types/internal-export/route-data";


@pcattori It looks like we have some circular deps here which are probably fine but it might be something we look into cleaning up later? react-router/internal imports RouteFiles from react-router so it doesn't seem like react-router should reach back into /internal stuff?

It looks like the underlying shared thing is ServerDataFrom/ClientDataFrom so maybe they should be exported as UNSAFE_ from react-router and pulled into /internal that way alongside RouteFiles?

brophdawg11 · 2025-05-15T15:35:37Z

packages/react-router/lib/types/internal-export/route-data.ts

@@ -1,12 +1,12 @@
 import type {


Anything directly exported from internal-export.ts now lives in the types/internal-export/ folder

github-actions · 2025-05-19T18:41:30Z

🤖 Hello there,

We just published version v0.0.0-nightly-30460939b-20250517 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This reverts commit a105445.

github-actions · 2025-05-25T13:48:24Z

🤖 Hello there,

We just published version 7.6.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

remix-cla-bot bot added the CLA Signed label May 8, 2025

brophdawg11 force-pushed the brophdawg11/build-hashes branch from 8ccf566 to daf7534 Compare May 8, 2025 21:22

pcattori reviewed May 8, 2025

View reviewed changes

brophdawg11 added 5 commits May 9, 2025 15:52

POC to remove hashes on built filenames

ae54bb9

Update to use splitting:false and multiple entry points

ccd9567

Revert "Update to use splitting:false and multiple entry points"

a04ce36

This reverts commit 7ad3bed.

Update prefetch test and package json for /internal export

081c7b7

Import Register fields from public API

d8b4226

brophdawg11 force-pushed the brophdawg11/build-hashes branch from d31f45f to d8b4226 Compare May 9, 2025 19:55

brophdawg11 added 3 commits May 9, 2025 16:06

WIP

f23b41d

Merge branch 'dev' into brophdawg11/build-hashes

2d985c2

Fix a few imports

0ca22a4

brophdawg11 commented May 15, 2025

View reviewed changes

Rename to internal-export to match dom-export

6199461

brophdawg11 commented May 15, 2025

View reviewed changes

brophdawg11 marked this pull request as ready for review May 15, 2025 15:36

brophdawg11 changed the title ~~POC to remove hashes on built filenames~~ Remove hashes on built filenames May 16, 2025

Add changeset

893f9cc

brophdawg11 merged commit a105445 into dev May 16, 2025
8 checks passed

brophdawg11 deleted the brophdawg11/build-hashes branch May 16, 2025 13:37

github-actions bot mentioned this pull request May 19, 2025

chore: Update version for release (pre) #13637

Merged

brophdawg11 added a commit that referenced this pull request May 20, 2025

Revert "Remove hashes on built filenames (#13567)"

d9c565a

This reverts commit a105445.

brophdawg11 added a commit that referenced this pull request May 24, 2025

Revert "Remove hashes on built filenames (#13567)"

b9bb1ca

This reverts commit a105445.

brophdawg11 mentioned this pull request May 24, 2025

Revert tsup changes from build #13667

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Remove hashes on built filenames #13567

Remove hashes on built filenames #13567

Uh oh!

brophdawg11 commented May 8, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 8, 2025 •

edited

Loading

Uh oh!

pcattori May 8, 2025

Uh oh!

brophdawg11 May 9, 2025

Uh oh!

brophdawg11 commented May 9, 2025

Uh oh!

brophdawg11 May 15, 2025

Uh oh!

brophdawg11 May 15, 2025

Uh oh!

brophdawg11 May 15, 2025

Uh oh!

brophdawg11 May 15, 2025

Uh oh!

brophdawg11 May 15, 2025

Uh oh!

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

github-actions bot commented May 25, 2025

Uh oh!

Uh oh!

Uh oh!

Remove hashes on built filenames #13567

Remove hashes on built filenames #13567

Uh oh!

Conversation

brophdawg11 commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pcattori May 8, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 May 9, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 commented May 9, 2025

Uh oh!

brophdawg11 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

github-actions bot commented May 25, 2025

Uh oh!

Uh oh!

brophdawg11 commented May 8, 2025 •

edited

Loading

changeset-bot bot commented May 8, 2025 •

edited

Loading