Split unstable_clientMiddleware export into its own chunk#12961
Closed
markdalgleish wants to merge 36 commits into
Closed
Split unstable_clientMiddleware export into its own chunk#12961markdalgleish wants to merge 36 commits into
unstable_clientMiddleware export into its own chunk#12961markdalgleish wants to merge 36 commits into
Conversation
|
Co-authored-by: Mark Dalgleish <mark.john.dalgleish@gmail.com> Co-authored-by: Steven Liao <114700648+steven-liao-rs@users.noreply.github.com>
This was referenced Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this PR is targeting the
brophdawg11/feat-middlewarebranch.Luckily this turned out to be fairly straightforward. The route manifest now has
hasClientMiddlewareandclientMiddlewareModulefields. It follows the same pattern asclientLoader/clientAction/HydrateFallbackwhere the manifest allows you to dynamically load theunstable_clientMiddlewareexport if it's in its own chunk, otherwise you can fall back to loading it from the main route module. Note that this behaviour is also guarded behind thefuture.unstable_splitRouteModulesflag, so it might be a good idea to encourage turning this flag on when using client middleware given the performance implications.