-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Closed
Description
React 0.13 brings parent-based context instead of owner-based context.
I'm getting tons of warnings with just published react@0.13.0-alpha.1 and the main problem seems to be that context is defined on router (makePath, makeHref, transitionTo, replaceWith, etc) but we're giving RouteHandler in render, so these keys don't appear in RouteHandler's parent-based context.
I still can't think quite straight about these changes but I assume some kind of wrapping RouteHandler into context parent will be necessary.
Edit (@mjackson): let's keep a checklist here:
- fix errors due to reliance on auto-binding. this will probably be clearer once we refactor
Routerinto a proper class instead of the hybrid it is today - stop using
createClass().type(thanks @taurose) - only keep
routeron context (see Too much stuff oncontext#744 / Update doc for Navigation api , goback method. Following up on #408 #855)
Metadata
Metadata
Assignees
Labels
No labels