Skip to content

href() builder produces invalid URL on optional segments #13055

Open
@cloudkite

Description

@cloudkite

I'm using React Router as a...

Framework

Reproduction

Given that i have a route in routes.ts as :

    route(
      "task/:taskId/v?/:versionId?",
      "task.route.tsx",
    ),

System Info

react-router v7.2

Used Package Manager

npm

Expected Behavior

href("task/:taskId/v?/:versionId?", { taskId: "123" }) === "task/123"
href("task/:taskId/v?/:versionId?", { taskId: "123", versionId: "hello" }) === "task/123/v/hello"

Actual Behavior

href("task/:taskId/v?/:versionId?", { taskId: "123" }) === "task/123/v?"
href("task/:taskId/v?/:versionId?", { taskId: "123", versionId: "hello" }) === "task/123/v?/hello"

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions