Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable v2_dev flag #243

Merged
merged 1 commit into from
Jul 7, 2023
Merged

feat: enable v2_dev flag #243

merged 1 commit into from
Jul 7, 2023

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

pcattori
pcattori approved these changes Jul 6, 2023
View reviewed changes
Copy link

@pcattori pcattori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also get rid of cross-env dependency and cross-env NODE_ENV=development in the dev script now.

pcattori
pcattori requested changes Jul 6, 2023
View reviewed changes
@MichaelDeBoey
Copy link
Member Author

@pcattori cross-env is still needed in the test:e2e:run script, so that one can't be removed

@MichaelDeBoey MichaelDeBoey requested a review from pcattori July 7, 2023 00:43
@pcattori pcattori merged commit 7f81973 into remix-run:main Jul 7, 2023
@MichaelDeBoey MichaelDeBoey deleted the enable-v2_dev-flag branch July 7, 2023 15:41
This was referenced Jul 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcattori pcattori pcattori approved these changes

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @pcattori @brophdawg11