Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @bunsenstraat :
Previously we were relying on an old version of chrome to allow the extension which is built for an older version to load properly. However this is quite unmaintainable ofc. In the long run. So we see it failing.
The latest version of chrome doesn't allow extension loading so I used the 'chrome for testing' version. That one does allow loading extensions, but you can't find the tab opened for the extension besides using the generated extension ID, which you then have to hardcode.
Previously we could switch tabs to the extension but that doesn't work anymore. Chrome prevents access to that tab in the window handles.
In previous version We used a special metamask build that would allow e2e to interact with the extension like filling in fields. In the new extension which I build from src using the gh action I made for that, that doesn't work anymore too. You can't control it anymore. No more JS filling in fields.
ALSO, fixed the AI e2e