Skip to content

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Sep 15, 2025

  • Matomo necessary toggle is on and disabled. So it cannot be set to off position.
  • Matomo with cookies option calls the method to disable cookies when disabled

Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit 16f4880
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/68ca89401d39ca000855306a
😎 Deploy Preview https://deploy-preview-6377--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Aniket-Engg Aniket-Engg requested a review from yann300 September 15, 2025 15:46
@Aniket-Engg Aniket-Engg added WIP ready-to-review PR ready to review and removed WIP labels Sep 15, 2025
dispatch({ type: 'SET_TOAST_MESSAGE', payload: { value: 'Credentials removed' } })
}
if (name === 'copilot/suggest/activate') plugin.emit('copilotChoiceUpdated', newValue)
if (name === 'matomo-perf-analytics') plugin.call('settings', 'updateMatomoPerfAnalyticsChoice', newValue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should also emit an event, same as above.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is not required here as there is no such event and it is not being listened anywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is just to be consistent with the line above plugin.emit('copilotChoiceUpdated', newValue)

@yann300 yann300 self-requested a review September 16, 2025 09:35
@Aniket-Engg Aniket-Engg merged commit 7237872 into master Sep 17, 2025
36 checks passed
@Aniket-Engg Aniket-Engg deleted the disableMatInSett branch September 17, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants