-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update environment & account list in udapp #6368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
12e7b4d
to
7cc7cb1
Compare
7cc7cb1
to
7b534b4
Compare
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7b534b4
to
a3077fb
Compare
2d58d3c
to
e6290e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are two owner account in account dropdown and I create a smart account selecting second owner account, it shows second owner address on modal but loads newly created smart account under first owner account and shows first owner address on toaster too.
@Aniket-Engg Hmm, I’ve been thinking about that too. This happens because Remix cannot directly control browser wallet accounts. That’s why I added a warning message inside the modal. But do you think there might be another alternative? ![]() |
ok yes. If we update the owner address from Remix IDE in the request, Metamask signing will not pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality wise looks fine to me
e6290e4
to
79515ce
Compare
1. Environment UI Updates:
2. Account UI Improvements: