Skip to content

Conversation

hsy822
Copy link
Collaborator

@hsy822 hsy822 commented Sep 11, 2025

1. Environment UI Updates:

  • Changed the existing list into a main menu and submenu structure.

2. Account UI Improvements:

  • Implemented a hierarchical list sorting logic to clearly show the relationship between EOAs (Owners) and their associated Smart Accounts.
  • Added "Owner" and "Smart" badges to make each account’s role easily identifiable.
  • Fixed a delay issue where the "Owner" info chip wasn’t updating immediately when selecting a Smart Account, ensuring the UI responds instantly.

Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit 9bac08c
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/68cb81d1120eb4000848301f
😎 Deploy Preview https://deploy-preview-6368--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are two owner account in account dropdown and I create a smart account selecting second owner account, it shows second owner address on modal but loads newly created smart account under first owner account and shows first owner address on toaster too.

@hsy822
Copy link
Collaborator Author

hsy822 commented Sep 17, 2025

If there are two owner account in account dropdown and I create a smart account selecting second owner account, it shows second owner address on modal but loads newly created smart account under first owner account and shows first owner address on toaster too.

@Aniket-Engg Hmm, I’ve been thinking about that too. This happens because Remix cannot directly control browser wallet accounts. That’s why I added a warning message inside the modal. But do you think there might be another alternative?

스크린샷 2025-09-17 오후 10 13 23

@Aniket-Engg
Copy link
Collaborator

If there are two owner account in account dropdown and I create a smart account selecting second owner account, it shows second owner address on modal but loads newly created smart account under first owner account and shows first owner address on toaster too.

@Aniket-Engg Hmm, I’ve been thinking about that too. This happens because Remix cannot directly control browser wallet accounts. That’s why I added a warning message inside the modal. But do you think there might be another alternative?

스크린샷 2025-09-17 오후 10 13 23

ok yes. If we update the owner address from Remix IDE in the request, Metamask signing will not pass.

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise looks fine to me

@hsy822 hsy822 force-pushed the refactor/deploy-run branch from e6290e4 to 79515ce Compare September 18, 2025 00:13
@hsy822 hsy822 merged commit f6c93a0 into master Sep 18, 2025
36 checks passed
@hsy822 hsy822 deleted the refactor/deploy-run branch September 18, 2025 04:16
@hsy822 hsy822 added the ready-to-review PR ready to review label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants