Skip to content

remove uneeded matomo keys #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

remove uneeded matomo keys #6365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/learneth/src/redux/models/workshop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,10 @@ const Model: ModelType = {
}
}
}
(<any>window)._paq.push(['trackEvent', 'learneth', 'load_repo', payload.name])
// we don't need to track the default repos
if (payload.name !== 'ethereum/remix-workshops' && payload.name !== 'remix-project-org/remix-workshops') {
(<any>window)._paq.push(['trackEvent', 'learneth', 'load_repo', payload.name])
}
},
*resetAll({ payload }, { put }) {
yield put({
Expand Down
4 changes: 1 addition & 3 deletions apps/remix-ide-e2e/src/tests/matomo.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,7 @@ module.exports = {
return (window as any)._paq
}, [], (res) => {
const expectedEvents = [
["trackEvent", "App", "Preload", "start"],
["trackEvent", "Storage", "activate", "indexedDB"],
["trackEvent", "App", "load"],
["trackEvent", "Storage", "activate", "indexedDB"]
];

const actualEvents = (res as any).value;
Expand Down
2 changes: 1 addition & 1 deletion apps/remix-ide/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class AppComponent {
'6fd22d6fe5549ad4c4d8fd3ca0b7816b.mod': 35 // remix desktop
}

_paq.push(['trackEvent', 'App', 'load']);
// _paq.push(['trackEvent', 'App', 'load']);
this.matomoConfAlreadySet = Registry.getInstance().get('config').api.exists('settings/matomo-perf-analytics')
this.matomoCurrentSetting = Registry.getInstance().get('config').api.get('settings/matomo-perf-analytics')

Expand Down
2 changes: 1 addition & 1 deletion apps/remix-ide/src/app/components/preload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import './styles/preload.css'
import isElectron from 'is-electron'
const _paq = (window._paq = window._paq || [])

_paq.push(['trackEvent', 'App', 'Preload', 'start'])
// _paq.push(['trackEvent', 'App', 'Preload', 'start'])

export const Preload = (props: any) => {
const [tip, setTip] = useState<string>('')
Expand Down
2 changes: 1 addition & 1 deletion apps/remix-ide/src/app/plugins/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class StoragePlugin extends Plugin {
}
}
const _paq = (window as any)._paq = (window as any)._paq || []
_paq.push(['trackEvent', 'Storage', 'used', this.formatString(storage)]);
// _paq.push(['trackEvent', 'Storage', 'used', this.formatString(storage)]);
return storage
}

Expand Down
2 changes: 1 addition & 1 deletion libs/remix-ui/solidity-compiler/src/lib/compiler-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ export const CompilerContainer = (props: CompilerContainerProps) => {
compileIcon.current.classList.remove('remixui_spinningIcon')
compileIcon.current.classList.remove('remixui_bouncingIcon')
if (!state.autoCompile || (state.autoCompile && state.matomoAutocompileOnce)) {
_paq.push(['trackEvent', 'compiler', 'compiled', 'solCompilationFinishedTriggeredByUser'])
// _paq.push(['trackEvent', 'compiler', 'compiled', 'solCompilationFinishedTriggeredByUser'])
_paq.push(['trackEvent', 'compiler', 'compiled', 'with_config_file_' + state.useFileConfiguration])
_paq.push(['trackEvent', 'compiler', 'compiled', 'with_version_' + _retrieveVersion()])
if (state.autoCompile && state.matomoAutocompileOnce) {
Expand Down