-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remix config #6351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remix config #6351
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
d3b6686
to
1ae7dbe
Compare
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cb37aba
to
f919177
Compare
}, | ||
|
||
'Should connect a local plugin': function (browser: NightwatchBrowser) { | ||
'Should connect a local plugin #pr': function (browser: NightwatchBrowser) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove the tag #pr
25ebec0
to
03cfdf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think user should be informed everytime remix.config file is updated
- I created a new workspace, there was some initial config. I set config for script runner and solidity compiler. When I reloaded the IDE, only solidity compiler config was there, nothing else
- Now I updated solidity compiler config and reloaded, configuration doesn't persist my changes and got reset
64216cd
to
bfd0786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases, remix.config.json is not opening from Solidity Compiler
This is a bug that is out scope of my PR. See #6396 |
bfd0786
to
6c43d70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality wise looks fine to me
Closes #6339