Skip to content

Conversation

joeizang
Copy link
Collaborator

fixes #6235

@joeizang joeizang self-assigned this Aug 12, 2025
@joeizang joeizang added the WIP label Aug 12, 2025
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit f961a64
🔍 Latest deploy log https://app.netlify.com/projects/remixproject/deploys/68a5c3dcbbc26300089b149c
😎 Deploy Preview https://deploy-preview-6248--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Aug 19, 2025
@joeizang joeizang requested a review from Aniket-Engg August 19, 2025 14:44
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-08-19 at 9 36 18 PM
  • Dropdown width is smaller than the parent element
  • clicking on Create new workspace doesn't close the dropdown
Screenshot 2025-08-19 at 9 37 30 PM

@joeizang joeizang requested a review from Aniket-Engg August 20, 2025 10:14
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-08-20 at 5 07 05 PM
  • There is no scroll for workspaces ad before
Screenshot 2025-08-20 at 5 07 37 PM
  • Git workspace is appearing like this

@joeizang joeizang requested a review from Aniket-Engg August 20, 2025 12:57
@Aniket-Engg Aniket-Engg merged commit 6343287 into master Aug 20, 2025
32 checks passed
@Aniket-Engg Aniket-Engg deleted the fix-rename-workspacetest branch August 20, 2025 13:02
// .execute(function () { document.querySelector('*[data-id="modalDialogCustomPromptTextCreate"]')['value'] = 'workspace_blank' })
.click('*[data-id="TemplatesSelection-modal-footer-ok-react"]')
.pause(100)
.pause()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix workspace rename delete e2e
3 participants