Show network name and ticker #6141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yann300
reviewed
Jul 8, 2025
| else name = 'Custom' | ||
|
|
||
| else { | ||
| const response = await fetch('https://chainid.network/chains.json') |
There was a problem hiding this comment.
Would it make sense to store this in the local storage? And if the current chaind isn't in the stored artefact to fetch it again.
yann300
reviewed
Jul 9, 2025
| networkNativeCurrency = networkDetails[id].nativeCurrency | ||
| } else { | ||
| const response = await fetch('https://chainid.network/chains.json') | ||
| if (response.ok) { |
There was a problem hiding this comment.
Is the case where the nativeCurrency can't be resolved is handled? like defaulting to eth or something?
There was a problem hiding this comment.
There was a problem hiding this comment.
if you want, I can do the same in this file too
There was a problem hiding this comment.
I am saying that because line 83 the local variable is set to null.
There was a problem hiding this comment.
ok, I will update that here too
yann300
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.