Skip to content

Fix using matomo api #6117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Fix using matomo api #6117

merged 1 commit into from
Jun 25, 2025

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Jun 25, 2025 •
edited
Loading

  • better to keep using matomo-analytics-consent for storing the last time matomo was accepted/rejected.
  • forgetMatomoPerfConsentGiven and setMatomoPerfConsentGiven are not in the matomo api, it is either disableCookies/setCookieConsentGiven .
  • by default cookies are disabled.
  • fix some redundancy in calling the matomo api.

@yann300 yann300 requested a review from joeizang June 25, 2025 14:37
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit c102580
🔍 Latest deploy log https://app.netlify.com/projects/remixproject/deploys/685c10768336c60009612c33
😎 Deploy Preview https://deploy-preview-6117--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yann300 yann300 merged commit f472eca into master Jun 25, 2025
33 checks passed
@yann300 yann300 deleted the fix_matomo_3 branch June 25, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeizang joeizang joeizang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yann300 @joeizang