Fix loading contracts from url #6093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yann300
force-pushed
the
fix_loading_contracts_from_url
branch
8 times, most recently
from
4d34bc3 to
ee7e683
Compare
| } | ||
|
|
||
| if (data.result[0].FileName === '') { | ||
| if (data.result[0].FileName === '.sol' && data.result[0].ContractName) { |
There was a problem hiding this comment.
Is this an error data.result[0].FileName === '.sol'? or do you meant data.result[0].FileName.endsWith('.sol')
There was a problem hiding this comment.
This is intended, this API isn't really consistent and in my test case the filename returned by the API ia .sol
yann300
force-pushed
the
fix_loading_contracts_from_url
branch
from
ee7e683 to
509ce93
Compare
ioedeveloper
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially_fix #6041
.debugfolder.