Skip to content

Conversation

ioedeveloper
Copy link
Collaborator

No description provided.

@ioedeveloper ioedeveloper requested review from yann300 and STetsing June 4, 2025 17:36
Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 4f726a2
🔍 Latest deploy log https://app.netlify.com/projects/remixproject/deploys/6852934ea532720008c12475
😎 Deploy Preview https://deploy-preview-6081--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yann300
Copy link
Contributor

yann300 commented Jun 5, 2025

When one switches file after accept/reject is displayed, the widget isn't removed.

const content = editorModelsState[currentFileRef.current].model.getValue()
const query = intl.formatMessage({ id: 'editor.generateDocumentationByAI' }, { content, currentFunction: currentFunction.current })
const output = await props.plugin.call('remixAI', 'code_explaining', query)
const originalFunctionComments = extractFunctionComments(content, 0, true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use insead functionNode.src.split(':')[0] which gives you the index in the file where the function is located.

@yann300
Copy link
Contributor

yann300 commented Jun 5, 2025

I often get this error: editor.main.js:66 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'endLineNumberExclusive')

@yann300
Copy link
Contributor

yann300 commented Jun 9, 2025

Getting this while trying to generate a documentatiion
remix

@STetsing
Copy link
Collaborator

@ioedeveloper would you describe the feature with test case/s?

@yann300 yann300 self-requested a review June 17, 2025 14:52
Copy link
Contributor

@yann300 yann300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a remaining bug that needs to be fixed (the widget not being anchored to the actual diff).

defineAndSetTheme(monacoRef.current)
})

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you put comment documentation in all the new useEffect?

@yann300 yann300 self-requested a review June 18, 2025 10:46
@yann300 yann300 enabled auto-merge June 18, 2025 10:46
@yann300 yann300 merged commit e0dc22a into master Jun 18, 2025
34 checks passed
@yann300 yann300 deleted the accept-reject branch June 18, 2025 10:49
This was referenced Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants