Refactor AA code to support more chains #5978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
changed the title
yann300
reviewed
May 2, 2025
| } | ||
| if (tx.fromSmartAccount && tx.value === "0" && err && err.error && err.error.indexOf('insufficient funds for transfer') !== -1) { | ||
| // Do not show dialog for insufficient funds as smart account may be using paymaster | ||
| if (tx.fromSmartAccount && tx.value === "0" && ( |
There was a problem hiding this comment.
I think we need to find a better way to check that...
below you are checking against err.error and not err..
should that be: err && err.error..indexOf('gas required exceeds allowance (0)') ?
yann300
reviewed
May 2, 2025
| async sendUserOp (tx) { | ||
| async sendUserOp (tx, chainId) { | ||
| // AA03: Add network name and public URL to support contract transactions using smart account | ||
| const aaSupportedNetworks = { |
There was a problem hiding this comment.
these constants should be put in an helper, so you don't duplicate it.
Aniket-Engg
force-pushed
the
aaChiado
branch
3 times, most recently
from
fa853d2 to
52989ee
Compare
yann300
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5718 (comment)