Skip to content

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Apr 9, 2025

fixes #5171

  • Remove all possible combinations from template explorer(including info on cells) and leave only one per class
  • all options the user can choose from will be added to the modal we currently use for the naming of workspace

@joeizang joeizang added the WIP label Apr 9, 2025
@joeizang joeizang requested review from LianaHus and Aniket-Engg April 9, 2025 23:49
@joeizang joeizang self-assigned this Apr 9, 2025
Copy link

netlify bot commented Apr 9, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 3ba4604
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/67ff73f18eb9600008ee4c9b
😎 Deploy Preview https://deploy-preview-5946--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang requested a review from ryestew April 10, 2025 12:43
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Apr 10, 2025
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-14 at 8 47 41 PM

increase the margin between textbox and customize template

Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The checkbox to initialize as a git repo does not work. (It should works even if you are not signed in).

  • There should be a little more vertical padding (or margin) between the name of the template and the text "Customize template"

image
  • The word "simple" should be replaced with "customizable" for all the choices.
image

@joeizang
Copy link
Collaborator Author

  • The checkbox to initialize as a git repo does not work. (It should works even if you are not signed in).
  • There should be a little more vertical padding (or margin) between the name of the template and the text "Customize template"
image * The word "simple" should be replaced with "customizable" for all the choices. image

You cannot use the git feature without signing in @ryestew

@Aniket-Engg Aniket-Engg force-pushed the oztemplates-contract-depsfix branch from 8411497 to 725113c Compare April 15, 2025 12:18
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality wise looks fine to me

@ryestew
Copy link
Collaborator

ryestew commented Apr 15, 2025

@joeizang - you can initialize a repo with Git without signing in. You can do that now on live and in your PR, after you make a new workspace (where you can't click the initialize checkbox), you can click the initialize button at the top of the FE.

This is a small point - and it should not delay the release. So if there is time, fix it now.

@ryestew
Copy link
Collaborator

ryestew commented Apr 15, 2025

The initialize checkbox is currently operating the way it is as it is in this PR - so we should merge this PR and decide how we want to use the initialize button separately.

@Aniket-Engg Aniket-Engg merged commit d559e72 into master Apr 16, 2025
34 checks passed
@Aniket-Engg Aniket-Engg deleted the oztemplates-contract-depsfix branch April 16, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal to add dependencies to OZ contract templates is no longer present
3 participants