Skip to content

Refactor and fix minor typos across multiple apps #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 17, 2025
Merged

Refactor and fix minor typos across multiple apps #5861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a7fd879
Update publish-action.yml
aso20455 Mar 11, 2025
861ecfb
Update ContractAddressInput.tsx
aso20455 Mar 11, 2025
56eec5a
Update App.css
aso20455 Mar 11, 2025
16e8449
Update app.tsx
aso20455 Mar 11, 2025
2c99e2e
Update scope.ts
aso20455 Mar 11, 2025
c5e6677
Update config.ts
aso20455 Mar 11, 2025
6f99752
Update App.tsx
aso20455 Mar 11, 2025
9ca22ad
Update index.html
aso20455 Mar 11, 2025
7774d6d
Update index.html
aso20455 Mar 11, 2025
19c60ca
Update publish-action.yml
aso20455 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/contract-verification/src/app/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ body {
}

a:focus {
background-color: var(bg-light) !important;
background-color: var(--bg-light) !important;
}

.fa-arrow-up-right-from-square::before { content: "\f08e"; }
Expand Down
2 changes: 1 addition & 1 deletion apps/contract-verification/src/app/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const App = () => {
const changedSubmittedContracts = { ...submittedContracts }

for (const receipt of pendingReceipts) {
await new Promise((resolve) => setTimeout(resolve, 500)) // avoid api rate limit exceed.
await new Promise((resolve) => setTimeout(resolve, 500)) // avoid api rate limit exceeding.

const { verifierInfo, receiptId } = receipt
if (receiptId) {
Expand Down
2 changes: 1 addition & 1 deletion apps/contract-verification/src/app/components/ContractAddressInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useEffect, useState, useContext } from 'react'
import { ethers } from 'ethers/'
import { ethers } from 'ethers'

interface ContractAddressInputProps {
label: string | any
Expand Down
2 changes: 1 addition & 1 deletion apps/doc-gen/src/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const App = () => {
<div className="p-3">
<h5 className="h-5 mb-3">
Compile a Solidity contract and generate its documentation as Markdown. (Right-click on a contract in the File
Explorer and select "Generate Docs" from the context menu.).
Explorer and select "Generate Docs" from the context menu).
</h5>
{fileName && (
<div className="border-bottom border-top px-2 py-3 justify-center align-items-center d-flex">
Expand Down
2 changes: 1 addition & 1 deletion apps/doc-gen/src/app/docgen/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export interface UserConfig {
pages?: 'single' | 'items' | 'files' | PageAssigner;

/**
* An array of sources subdirectories that should be excluded from
* An array of source subdirectories that should be excluded from
* documentation, relative to the contract sources directory.
*/
exclude?: string[];
Expand Down
2 changes: 1 addition & 1 deletion apps/doc-gen/src/app/docgen/utils/scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function getContractsInScope(item: DocItemWithContext) {
Object.assign(scope, importedScope);
} else {
for (const a of i.symbolAliases) {
// Delayed function call supports circular dependencies
// Delayed function call support circular dependencies
scope[a.local ?? a.foreign.name] = importedScope[a.foreign.name] ?? (() => importedScope[a.foreign.name]!());
}
}
Expand Down
2 changes: 1 addition & 1 deletion apps/learneth/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1" />
<!-- <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.8.1/css/all.css" integrity="sha384-50oBUHEmvpQ+1lW4y57PTFmhCaXp0ML5d60M1M7uH2+nqUivzIebhndOJK28anvf" crossorigin="anonymous"/> -->
<!-- <link href="https://cdn.jsdelivr.net/npm/bootstrap@5.2.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-rbsA2VBKQhggwzxH7pPCaAqO46MgnOM80zW1RWuH61DGLwZJEdK2Kadq2F9CUG65" crossorigin="anonymous"> -->
<link rel="stylesheet" integrity="ha384-50oBUHEmvpQ+1lW4y57PTFmhCaXp0ML5d60M1M7uH2+nqUivzIebhndOJK28anvf"
<link rel="stylesheet" integrity="sha384-50oBUHEmvpQ+1lW4y57PTFmhCaXp0ML5d60M1M7uH2+nqUivzIebhndOJK28anvf"
crossorigin="anonymous" href="https://use.fontawesome.com/releases/v5.8.1/css/all.css">
</head>
<body>
Expand Down
2 changes: 1 addition & 1 deletion apps/noir-compiler/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1" />
<!-- <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.8.1/css/all.css" integrity="sha384-50oBUHEmvpQ+1lW4y57PTFmhCaXp0ML5d60M1M7uH2+nqUivzIebhndOJK28anvf" crossorigin="anonymous"/> -->
<!-- <link href="https://cdn.jsdelivr.net/npm/bootstrap@5.2.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-rbsA2VBKQhggwzxH7pPCaAqO46MgnOM80zW1RWuH61DGLwZJEdK2Kadq2F9CUG65" crossorigin="anonymous"> -->
<link rel="stylesheet" integrity="ha384-50oBUHEmvpQ+1lW4y57PTFmhCaXp0ML5d60M1M7uH2+nqUivzIebhndOJK28anvf"
<link rel="stylesheet" integrity="sha384-50oBUHEmvpQ+1lW4y57PTFmhCaXp0ML5d60M1M7uH2+nqUivzIebhndOJK28anvf"
crossorigin="anonymous" href="https://use.fontawesome.com/releases/v5.8.1/css/all.css">
</head>
<body>
Expand Down