Skip to content

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Mar 6, 2025

fixes #5736

  • Creates a new stateful DropDownLabel component
  • Updates label when chainId changes from metamask.

@joeizang joeizang added the WIP label Mar 6, 2025
@joeizang joeizang requested review from ryestew and LianaHus March 6, 2025 09:13
@joeizang joeizang self-assigned this Mar 6, 2025
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 7aaa6ea
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/67d3167bce2621000937a499
😎 Deploy Preview https://deploy-preview-5844--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Mar 6, 2025
@joeizang joeizang force-pushed the udapp-env-dropdown branch 3 times, most recently from 684fdae to e6b87d1 Compare March 10, 2025 10:33
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-10 at 11 20 21 PM

rocket icon stays even on changing network from L2

<Dropdown.Item
key={name}
onClick={async () => {
console.log('name when switching selected env', name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove log

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done

@joeizang joeizang force-pushed the udapp-env-dropdown branch from 694c992 to 8bb0898 Compare March 10, 2025 22:25
@joeizang joeizang requested a review from Aniket-Engg March 11, 2025 15:28
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I select Injected Provider - Metamask, Remix IDE breaks for me

{ name: 'Dev - Foundry Provider', value: 'foundry-provider', chainId: 31337 },
{ name: 'Dev - Ganache Provider', value: 'ganache-provider', chainId: 1741104841094 },
]
console.log('runTabState', runTabState)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove log

@joeizang joeizang force-pushed the udapp-env-dropdown branch from 5192deb to d532a44 Compare March 11, 2025 18:54
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise looks fine to me

@joeizang joeizang force-pushed the udapp-env-dropdown branch 5 times, most recently from 7f223b2 to 28fb897 Compare March 13, 2025 10:42
@joeizang joeizang force-pushed the udapp-env-dropdown branch from dc6bd0b to 480b633 Compare March 13, 2025 13:39
@joeizang joeizang merged commit 1c645dd into master Mar 13, 2025
34 checks passed
@joeizang joeizang deleted the udapp-env-dropdown branch March 13, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment Select box with L2-Optimism
3 participants