Skip to content

Conversation

0xkazak
Copy link
Contributor

@0xkazak 0xkazak commented Feb 2, 2025

I've cleaned up some duplicated logic, added necessary checks, and handled edge cases more gracefully. Specifically:

  • Removed duplicate code in the if and else blocks.
  • Added checks to ensure cb and done_cb exist before calling them.
  • Cleaned up error handling by removing unnecessary return values in catch blocks.
  • Added a proper check for the presence of streamResponse.body to avoid potential issues with missing data.

These changes should make the code cleaner, safer, and more maintainable.

Copy link

netlify bot commented Feb 2, 2025

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3dafd97

@Aniket-Engg Aniket-Engg requested a review from STetsing March 27, 2025 14:18
@0xkazak
Copy link
Contributor Author

0xkazak commented Apr 8, 2025

STetsing, merge it

Fix code duplication, add error handling, and improve checks for stream response
@Aniket-Engg Aniket-Engg merged commit 46879c8 into remix-project-org:master May 19, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants