-
Notifications
You must be signed in to change notification settings - Fork 1.2k
create safe smart account #5614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7816021
to
35f56c9
Compare
let bytecode = tx.data | ||
|
||
const expectedDeploymentAddress = getContractAddress({ | ||
bytecode: keccak256(bytecode), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the doc, parameters seem wrong: https://viem.sh/docs/utilities/getContractAddress.html#opcode-optional
I click on "Create safe smart account" but nothing happen, and the following is logged:
|
That needs an API key, which is not there in PR |
can we use a service API key? |
4865515
to
3065ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
"udapp.createSmartAccount": "Create safe smart account", | ||
"udapp.createSmartAccountAlpha": "Create safe smart account [ALPHA]", | ||
"udapp.createSmartAccountDesc1":"A smart account is also known as a smart contract account.", | ||
"udapp.createSmartAccountDesc2":"A Safe Smart Account is a Smart Account with multi-signature functionality at its core. ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
"udapp.reset": "Reset", | ||
"udapp.delete": "Delete", | ||
"udapp.injectedTitle": "Unfortunately it's not possible to create an account using injected provider. Please create the account directly from your provider (i.e metamask or other of the same type).", | ||
"udapp.createSmartAccount": "Create safe smart account", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's either capitalized or not. you have both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
"udapp.createSmartAccountDesc2":"A Safe Smart Account is a Smart Account with multi-signature functionality at its core. ", | ||
"udapp.createSmartAccountDesc3":"Smart Account created here will by default have a PAYMASTER attached to it, which means using this account GASLESS transactions can be made, only for SEPOLIA testnet.", | ||
"udapp.createSmartAccountDesc4":"Selected account i.e {owner} will be OWNER for this smart account. Owner account is used to sign each transaction(user-operation) made using smart account.", | ||
"udapp.createSmartAccountDesc5":"To make existence of this smart contract account on Blockchain, an initial transaction will be made which will require signing at next step.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make existence sounds "complicated".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Related to #5718
This adds code for creating a safe smart account and making a transaction using smart account using a paymaster.
Functionality has been checked and demonstrated locally. For now, it is hidden from UI. A follow up PR will allow to use it more publicly.