Skip to content

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Jan 7, 2025

Related to #5718

This adds code for creating a safe smart account and making a transaction using smart account using a paymaster.

Functionality has been checked and demonstrated locally. For now, it is hidden from UI. A follow up PR will allow to use it more publicly.

@Aniket-Engg Aniket-Engg added the WIP label Jan 7, 2025
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit ec0f4d3
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/67ebdf991123bf0008caca65
😎 Deploy Preview https://deploy-preview-5614--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

let bytecode = tx.data

const expectedDeploymentAddress = getContractAddress({
bytecode: keccak256(bytecode),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yann300
Copy link
Contributor

yann300 commented Mar 3, 2025

I click on "Create safe smart account" but nothing happen, and the following is logged:

Uncaught (in promise) HttpRequestError: HTTP request failed.

Status: 401
URL: https://api.pimlico.io/v2/sepolia/rpc?apikey=
Request body: {"method":"pimlico_getUserOperationGasPrice","params":[]}

Details: "Unauthorized"
Version: viem@2.22.3
    at Object.request (vendor.0.62.0-dev.1740773003639.js:240105:27)
    at async fn (vendor.0.62.0-dev.1740773003639.js:229735:25)
    at async request (vendor.0.62.0-dev.1740773003639.js:229739:45)
    at async delay.count.count (vendor.0.62.0-dev.1740773003639.js:236722:24)
    at async attemptRetry (vendor.0.62.0-dev.1740773003639.js:239923:30)
    ```

@Aniket-Engg
Copy link
Collaborator Author

I click on "Create safe smart account" but nothing happen, and the following is logged:

Uncaught (in promise) HttpRequestError: HTTP request failed.

Status: 401
URL: https://api.pimlico.io/v2/sepolia/rpc?apikey=
Request body: {"method":"pimlico_getUserOperationGasPrice","params":[]}

Details: "Unauthorized"
Version: viem@2.22.3
    at Object.request (vendor.0.62.0-dev.1740773003639.js:240105:27)
    at async fn (vendor.0.62.0-dev.1740773003639.js:229735:25)
    at async request (vendor.0.62.0-dev.1740773003639.js:229739:45)
    at async delay.count.count (vendor.0.62.0-dev.1740773003639.js:236722:24)
    at async attemptRetry (vendor.0.62.0-dev.1740773003639.js:239923:30)
    ```

That needs an API key, which is not there in PR

@yann300
Copy link
Contributor

yann300 commented Mar 3, 2025

can we use a service API key?

@Aniket-Engg Aniket-Engg force-pushed the gnosAA branch 3 times, most recently from 4865515 to 3065ce6 Compare March 5, 2025 16:59
Copy link

@BoomchainLabs BoomchainLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

@BoomchainLabs BoomchainLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Aniket-Engg Aniket-Engg added ready-to-review PR ready to review and removed WIP labels Apr 1, 2025
@Aniket-Engg Aniket-Engg requested a review from LianaHus April 1, 2025 09:57
"udapp.createSmartAccount": "Create safe smart account",
"udapp.createSmartAccountAlpha": "Create safe smart account [ALPHA]",
"udapp.createSmartAccountDesc1":"A smart account is also known as a smart contract account.",
"udapp.createSmartAccountDesc2":"A Safe Smart Account is a Smart Account with multi-signature functionality at its core. ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"udapp.reset": "Reset",
"udapp.delete": "Delete",
"udapp.injectedTitle": "Unfortunately it's not possible to create an account using injected provider. Please create the account directly from your provider (i.e metamask or other of the same type).",
"udapp.createSmartAccount": "Create safe smart account",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's either capitalized or not. you have both

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"udapp.createSmartAccountDesc2":"A Safe Smart Account is a Smart Account with multi-signature functionality at its core. ",
"udapp.createSmartAccountDesc3":"Smart Account created here will by default have a PAYMASTER attached to it, which means using this account GASLESS transactions can be made, only for SEPOLIA testnet.",
"udapp.createSmartAccountDesc4":"Selected account i.e {owner} will be OWNER for this smart account. Owner account is used to sign each transaction(user-operation) made using smart account.",
"udapp.createSmartAccountDesc5":"To make existence of this smart contract account on Blockchain, an initial transaction will be made which will require signing at next step.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make existence sounds "complicated".

Copy link
Collaborator Author

@Aniket-Engg Aniket-Engg Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@remix-project-org remix-project-org deleted a comment from gitguardian bot Apr 2, 2025
@Aniket-Engg Aniket-Engg merged commit 8bed08f into master Apr 2, 2025
34 checks passed
@Aniket-Engg Aniket-Engg deleted the gnosAA branch April 2, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants