Skip to content

Conversation

ioedeveloper
Copy link
Collaborator

@ioedeveloper ioedeveloper commented Jan 6, 2025

  • Refactored components from circom compiler for use in Noir compiler, to avoid duplicate components.
  • Create a parser for Noir circuit, because @noir-lang/noir_wasm lib does not provide a native parser.
  • Modify webpack to rewrite @noir-lang/noir_wasm package.json, because it does not correctly export the wasm compiler for the browser.
  • Resolve dependencies in a flat directory structure ('/src') while catching circular dependencies. Note: Still to be improved.
  • Display parsing errors in the editor.
  • Add webp icon provided by @ryestew
    Related Issues:
    Support Noir Compiler: Part 2 #5732

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 31ae5ab
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/67b45ee267165800081fb8f2
😎 Deploy Preview https://deploy-preview-5605--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300

This comment was marked as resolved.

@ioedeveloper
Copy link
Collaborator Author

got unreachable error after compiling (test.nr)

fn main(age: u8) {
  assert(age >= 18);
}

This noir circuit compiles fine for me @yann300

@yann300
Copy link
Contributor

yann300 commented Feb 11, 2025

  • put compilation result to the build folder

@yann300
Copy link
Contributor

yann300 commented Feb 11, 2025

@yann300
Copy link
Contributor

yann300 commented Feb 11, 2025

  • check error management

@yann300
Copy link
Contributor

yann300 commented Feb 11, 2025

  • more feedback when the compilation succeed.

@yann300
Copy link
Contributor

yann300 commented Feb 17, 2025

  • put compilation result to the build folder

I think it needs to be at the root, not under src/build

@Aniket-Engg Aniket-Engg merged commit 72e185d into master Feb 18, 2025
33 of 34 checks passed
@Aniket-Engg Aniket-Engg deleted the noir branch February 18, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants