Await async modals #1901
Merged
Await async modals #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undo compiler unde compiler undo coompiler
bunsenstraat
force-pushed
the
awaitasyncmodals
branch
from
8218649 to
2b4e753
Compare
yann300
reviewed
Jan 10, 2022
| } | ||
| } | ||
| await this.call('modal', 'modal', mod) | ||
| else { |
There was a problem hiding this comment.
there isn't a hide handle?
There was a problem hiding this comment.
There is no need. If return is undefined it is hide, if false it is cancel but in this case they both cause the plug-in to cancel
yann300
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.