London support #1412
Merged
London support #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
london-support
branch
4 times, most recently
from
e4a73ae to
4944a39
Compare
yann300
commented
Jul 28, 2021
| el.querySelector('#gasprice').value = gasPriceValue | ||
| onGasPriceChange() | ||
| } | ||
| if (el.querySelector('#maxfee') && network && network.lastBlock && network.lastBlock.baseFeePerGas && el.querySelector('#maxfee')) { |
yann300
commented
Jul 28, 2021
| const block = await web3.eth.getBlock('latest') | ||
| // we can't use the blockGasLimit cause the next blocks could have a lower limit : https://github.com/ethereum/remix/issues/506 | ||
| this.blockGasLimit = (block && block.gasLimit) ? Math.floor(block.gasLimit - (5 * block.gasLimit) / 1024) : this.blockGasLimitDefault | ||
| this.lastBlock = block |
There was a problem hiding this comment.
_updateChainContext should be updated as soon as possible when a new provider is switched to.
There was a problem hiding this comment.
yann300
commented
Jul 28, 2021
| "@ethereumjs/vm": "^5.4.1", | ||
| "@ethereumjs/block": "^3.4.0", | ||
| "@ethereumjs/tx": "^3.3.0", | ||
| "@ethereumjs/vm": "^5.5.0", |
There was a problem hiding this comment.
might need to check what to do with maxFee and maxPriorityFee.
yann300
requested review from
Aniket-Engg,
LianaHus,
bunsenstraat and
ioedeveloper
Aniket-Engg
reviewed
Jul 29, 2021
LianaHus
reviewed
Aug 2, 2021
| <div> | ||
| <div>You are about to create a transaction on the Main Network. Confirm the details to send the info to your provider. | ||
| <br>The provider for many users is MetaMask. The provider will ask you to sign the transaction before it is sent to the Main Network.</div> | ||
| <div>You are about to create a transaction on ${network.name}. Confirm the details to send the info to your provider. |
There was a problem hiding this comment.
maybe "...on ${network.name} network. ..." would be the correct info
LianaHus
reviewed
Aug 2, 2021
| <div>You are about to create a transaction on the Main Network. Confirm the details to send the info to your provider. | ||
| <br>The provider for many users is MetaMask. The provider will ask you to sign the transaction before it is sent to the Main Network.</div> | ||
| <div>You are about to create a transaction on ${network.name}. Confirm the details to send the info to your provider. | ||
| <br>The provider for many users is MetaMask. The provider will ask you to sign the transaction before it is sent to ${network.name}.</div> |
|
Some notes about UI changes after a discussion/call (@Aniket-Engg @LianaHus)
|
Aniket-Engg
force-pushed
the
london-support
branch
from
880554a to
c2e8a3c
Compare
Aniket-Engg
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ask the user to input maxFee and maxPriorityFee if the chain is eip 1559 enabled.
references for the implementation:
https://hackmd.io/4YVYKxxvRZGDto7aq7rVkg?view
https://github.com/ethereum/eth1.0-specs/blob/master/network-upgrades/ecosystem-readiness.md
EDIT: the last set of changes updates remix-ide to it default to London when the app starts
EDIT: this commit 533d7f9
use berlinroll back unit testing to use berlin, fix for making sure tests run with london will come later