Skip to content

Conversation

rorye
Copy link
Contributor

@rorye rorye commented Jul 27, 2021

Fixes #1378

Before:

Screen Shot 2021-07-27 at 8 15 20 pm

After:

Screen Shot 2021-07-27 at 8 14 30 pm

@LianaHus
Copy link
Collaborator

Thanks for the PR

IMHO we should change the font color of the theme as well

it's the main color of text, you can find it here:

.ace-remixDark {
background-color: #222336;
color: #a2a3bd;
}\

#a2a3bd => #d5d5e9

Copy link
Collaborator

@LianaHus LianaHus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comment

@rorye
Copy link
Contributor Author

rorye commented Jul 28, 2021

Thanks for the PR

IMHO we should change the font color of the theme as well

it's the main color of text, you can find it here:

.ace-remixDark {
background-color: #222336;
color: #a2a3bd;
}\

#a2a3bd => #d5d5e9

Have made this change now, thanks.

@rorye rorye closed this Jul 29, 2021
@rorye rorye deleted the fix-dark-theme-highlight branch July 29, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments have the same grey color as variable names and functions actions (would be white). it's confusing

2 participants